Improving function calls to take less arguments

readmemory/handler.go

@@ -0,0 +1,23 @@
+package readmemory
+
+import (
+	windows "golang.org/x/sys/windows"
+)
+
+type Handle struct {
+	processHandle         windows.Handle
+	baseAddress           int64
+	procReadProcessMemory *windows.Proc
+}
+
+func NewHandle(processName string) Handle {
+	var handle Handle
+
+	pid, _ := bindDefaultProcess(processName)
+	handle.processHandle, _ = windows.OpenProcess(0x0010|windows.PROCESS_VM_READ|windows.PROCESS_QUERY_INFORMATION, false, pid)
+	handle.procReadProcessMemory = windows.MustLoadDLL("kernel32.dll").MustFindProc("ReadProcessMemory")
+	baseAddress, _ := memoryReadInit(pid, processName)
+	handle.baseAddress = baseAddress
+
+	return handle
+}

readmemory/memory.go

@@ -2,9 +2,7 @@ package readmemory
 
 import (
 	"encoding/binary"
-	"math"
 	"path/filepath"
-	"strconv"
 	"unsafe"
 
 	"github.com/0xrawsec/golang-win32/win32"
@@ -12,7 +10,7 @@ import (
 	windows "golang.org/x/sys/windows"
 )
 
-func MemoryReadInit(pid uint32, targetModuleFilename string) (int64, bool) {
+func memoryReadInit(pid uint32, targetModuleFilename string) (int64, bool) {
 	win32handle, _ := kernel32.OpenProcess(0x0010|windows.PROCESS_VM_READ|windows.PROCESS_QUERY_INFORMATION, win32.BOOL(0), win32.DWORD(pid))
 	moduleHandles, _ := kernel32.EnumProcessModules(win32handle)
 	for _, moduleHandle := range moduleHandles {
@@ -26,34 +24,15 @@ func MemoryReadInit(pid uint32, targetModuleFilename string) (int64, bool) {
 	return 0, false
 }
 
-func readMemoryAt(handle windows.Handle, procReadProcessMemory *windows.Proc, address int64) float32 {
-	var (
-		data   [4]byte
-		length uint32
-	)
-
-	procReadProcessMemory.Call(
-		uintptr(handle),
-		uintptr(address),
-		uintptr(unsafe.Pointer(&data[0])),
-		uintptr(len(data)),
-		uintptr(unsafe.Pointer(&length)),
-	)
-
-	bits := binary.LittleEndian.Uint32(data[:])
-	float := math.Float32frombits(bits)
-	return float
-}
-
-func readMemoryAtByte8(handle windows.Handle, procReadProcessMemory *windows.Proc, address int64) uint64 {
+func (handle *Handle) ReadMemoryAtByte8(address int64) uint64 {
 	var (
 		data   [8]byte
 		length uint32
 	)
 
-	procReadProcessMemory.Call(
-		uintptr(handle),
-		uintptr(address),
+	handle.procReadProcessMemory.Call(
+		uintptr(handle.processHandle),
+		uintptr(handle.baseAddress+address),
 		uintptr(unsafe.Pointer(&data[0])),
 		uintptr(len(data)),
 		uintptr(unsafe.Pointer(&length)),
@@ -63,15 +42,15 @@ func readMemoryAtByte8(handle windows.Handle, procReadProcessMemory *windows.Pro
 	return byte8
 }
 
-func ReadMemoryAtByte1(handle windows.Handle, procReadProcessMemory *windows.Proc, address int64) byte {
+func (handle *Handle) ReadMemoryAtByte1(address int64) byte {
 	var (
 		data   [1]byte
 		length uint32
 	)
 
-	procReadProcessMemory.Call(
-		uintptr(handle),
-		uintptr(address),
+	handle.procReadProcessMemory.Call(
+		uintptr(handle.processHandle),
+		uintptr(handle.baseAddress+address),
 		uintptr(unsafe.Pointer(&data[0])),
 		uintptr(len(data)),
 		uintptr(unsafe.Pointer(&length)),
@@ -80,15 +59,15 @@ func ReadMemoryAtByte1(handle windows.Handle, procReadProcessMemory *windows.Pro
 	return data[0]
 }
 
-func ReadMemoryAtByte2(handle windows.Handle, procReadProcessMemory *windows.Proc, address int64) uint16 {
+func (handle *Handle) ReadMemoryAtByte2(address int64) uint16 {
 	var (
 		data   [2]byte
 		length uint32
 	)
 
-	procReadProcessMemory.Call(
-		uintptr(handle),
-		uintptr(address),
+	handle.procReadProcessMemory.Call(
+		uintptr(handle.processHandle),
+		uintptr(handle.baseAddress+address),
 		uintptr(unsafe.Pointer(&data[0])),
 		uintptr(len(data)),
 		uintptr(unsafe.Pointer(&length)),
@@ -96,16 +75,3 @@ func ReadMemoryAtByte2(handle windows.Handle, procReadProcessMemory *windows.Pro
 
 	return binary.LittleEndian.Uint16(data[:])
 }
-
-type staticPointer struct {
-	baseOffset int64
-	offsets    []string
-}
-
-func sumHex(aHex string, bHex string) string {
-	aDecimal, _ := strconv.ParseInt(aHex, 16, 0)
-	bDecimal, _ := strconv.ParseInt(bHex, 16, 0)
-	resultDecimal := aDecimal + bDecimal
-	resultHex := strconv.FormatInt(resultDecimal, 16)
-	return resultHex
-}

readmemory/processes.go

@@ -69,7 +69,7 @@ func newWindowsProcess(e *windows.ProcessEntry32) WindowsProcess {
 	}
 }
 
-func BindDefaultProcess(defaultName string) (uint32, bool) {
+func bindDefaultProcess(defaultName string) (uint32, bool) {
 	procs, err := processes()
 	if err != nil {
 		return 0, false